Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readability on mobile #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

mendaomn
Copy link

@mendaomn mendaomn commented May 2, 2020

Hey, thank you for this great article!

I wanted to share this with my family, but on mobile it's quite hard to read (mainly font size, font weight and horizontal scrolling) and they don't have a laptop

I figured I'd put together this PR whose only aim is to improve the readability on mobile devices!

You can take a look at the final result at: https://mendaomn.github.io/covid-19/index.html

Let me know if there's anything I can do to make this PR better

@cauerego
Copy link

cauerego commented May 4, 2020

it looks amazing!

except for the big playable interactive graphs. 🤣

they are all to the right of the screen, and can't be scrolled.

@mendaomn
Copy link
Author

mendaomn commented May 4, 2020

Shoot! Will definitely try and fix that! (horizontal scrolling is probably going to be the best option, will see)

@cauerego
Copy link

cauerego commented May 4, 2020

tell me if you need screenshots, videos, whatever i can to help.

@mendaomn
Copy link
Author

mendaomn commented May 5, 2020

It should now be a bit easier to interact with the simulations on mobile, what do you think?

Weirdly, I don't seem able to run those iframes locally :(

@cauerego
Copy link

wow, that was too fast for me!

yeah, it's better.

also, it looks like ncase updated a few things in his, but this still looks generally so much better than his!

for reading, at least.

still...

i miss some way to overview the graphs.

even using in landscape, i can't see the whole thing.

rather have the graph zoomed out and be able to zoom in than the scrolling as it is.

and, because of that, i rather have the current site as it is now (much worse to read in general) but being able to fully see the graphs. 🤟

@mendaomn
Copy link
Author

Makes perfect sense! Feel free to close this then 😊

@cauerego
Copy link

cauerego commented May 16, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants